Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor #195

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor #195

wants to merge 2 commits into from

Conversation

hzhreal
Copy link

@hzhreal hzhreal commented Dec 16, 2024

I saw that you are using an older version of my port. If you are interested I updated the file. Functionality remains the same.

Most significant changes:

  • Use sceKernel wrappers instead of inline assembly (sys_open)
  • Remove unnecessary memset calls

@hzhreal hzhreal requested a review from bucanero as a code owner December 16, 2024 14:15
@bucanero
Copy link
Owner

hi @hzhreal , thanks for the PR 👍
I'll review it and test it out, probably after I release the new version.

One question, is there any reason for those dummy char arrays? I see them defined and then UNUSED(dummy), not sure if they're needed for something or we could also get rid of them?

bucanero
bucanero reviewed Dec 17, 2024
View reviewed changes
source/sd.c Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bucanero bucanero bucanero left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hzhreal @bucanero