Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement unambiguous compressed blobs bytestream upload early return #527

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Implement unambiguous compressed blobs bytestream upload early return #527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion server/grpc_bytestream.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,11 @@ func (s *grpcServer) Write(srv bytestream.ByteStream_WriteServer) error {
exists, _ := s.cache.Contains(srv.Context(), cache.CAS, hash, size)
if exists {
// Blob already exists, return without writing anything.
resp.CommittedSize = size
if cmp == casblob.Identity {
resp.CommittedSize = size
} else {
resp.CommittedSize = -1
}
putResult <- io.EOF
return
}
Expand Down
2 changes: 1 addition & 1 deletion server/grpc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,7 +975,7 @@ func TestGrpcByteStreamZstdWrite(t *testing.T) {
if err != nil {
t.Fatal(err)
}
if bswResp.CommittedSize != int64(len(compressedBlob)) {
if bswResp.CommittedSize != int64(len(compressedBlob)) && bswResp.CommittedSize != -1 {
t.Fatalf("Error: expected to write: %d but committed: %d\n",
len(testBlob), bswResp.CommittedSize)
}
Expand Down