Configure button disabled when Magento_Paypal module is disabled. #18
Comments
|
Thank you @basvanpoppel . We are aware of this issue. From what i understand you allready had contact with our technical support team who provided you the following link: https://support.buckaroo.nl/categorie%C3%ABn/plugins/magento-2/nuttige-know-how/my-configure-button-is-not-clickable-within-the-configuration-en Can you confirm that everything works for you right now? |
|
The workaround works, yes. Thanks! |
|
Great, thanks for the confirmation. |
|
It is weird that this issue is marked as closed. Providing a workaround cannot be really called a fix right? Modules PayPal, InstantPurchase and Vault are not required for basic Buckaroo usage right? Maybe better to provide these checks at the payment methods or settings that really depend on them? |
|
@rikwillems I aggree with you but this issue is on our backlog but since it is not critical and there is a work arround i don't see the reason to keep this open for now. |
CyberSecutor
added a commit
to CyberSecutor/Magento2
that referenced
this issue
Dec 3, 2020
When setting a samesite cookie behind an SSL offloading loadbalancer the secure flag does not get set automatically. This raises an exception causing a 502 denial of service. ``` "0":"Cookie must be secure in order to use the SameSite None directive.","1":"buckaroo-it#1 BuckarooMagento2ModelPluginFixSession->beforeSetPublicCookie() called at [vendor/magento/framework/Interception/Interceptor.php:121] buckaroo-it#2 MagentoFrameworkStdlibCookiePhpCookieManagerInterceptor->MagentoFrameworkInterception{closure}() called at [vendor/magento/framework/Interception/Interceptor.php:153] buckaroo-it#3 MagentoFrameworkStdlibCookiePhpCookieManagerInterceptor->___callPlugins() called at [generated/code/Magento/Framework/Stdlib/Cookie/PhpCookieManager/Interceptor.php:23] buckaroo-it#4 MagentoFrameworkStdlibCookiePhpCookieManagerInterceptor->setPublicCookie() called at [vendor/magento/framework/Session/SessionManager.php:247] buckaroo-it#5 MagentoFrameworkSessionSessionManager->renewCookie() called at [vendor/magento/framework/Session/SessionManager.php:212] buckaroo-it#6 MagentoFrameworkSessionSessionManager->start() called at [vendor/magento/framework/Interception/Interceptor.php:58] buckaroo-it#7 MagentoFrameworkSessionGenericInterceptor->___callParent() called at [vendor/magento/framework/Interception/Interceptor.php:138] buckaroo-it#8 MagentoFrameworkSessionGenericInterceptor->MagentoFrameworkInterception{closure}() called at [vendor/magento/framework/Interception/Interceptor.php:153] buckaroo-it#9 MagentoFrameworkSessionGenericInterceptor->___callPlugins() called at [generated/code/Magento/Framework/Session/Generic/Interceptor.php:23] buckaroo-it#10 MagentoFrameworkSessionGenericInterceptor->start() called at [vendor/magento/framework/Session/SessionManager.php:141] buckaroo-it#11 MagentoFrameworkSessionSessionManager->__construct() called at [generated/code/Magento/Framework/Session/Generic/Interceptor.php:14] buckaroo-it#12 MagentoFrameworkSessionGenericInterceptor->__construct() called at [vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php:121] buckaroo-it#13 MagentoFrameworkObjectManagerFactoryAbstractFactory->createObject() called at [vendor/magento/framework/ObjectManager/Factory/Compiled.php:108] buckaroo-it#14 MagentoFrameworkObjectManagerFactoryCompiled->create() called at [vendor/magento/framework/ObjectManager/Factory/Compiled.php:150] buckaroo-it#15 MagentoFrameworkObjectManagerFactoryCompiled->get() called at [vendor/magento/framework/ObjectManager/Factory/Compiled.php:79] buckaroo-it#16 MagentoFrameworkObjectManagerFactoryCompiled->create() called at [vendor/magento/framework/ObjectManager/Factory/Compiled.php:150] buckaroo-it#17 MagentoFrameworkObjectManagerFactoryCompiled->get() called at [vendor/magento/framework/ObjectManager/Factory/Compiled.php:79] buckaroo-it#18 MagentoFrameworkObjectManagerFactoryCompiled->create() called at [vendor/magento/framework/ObjectManager/Factory/Compiled.php:150] buckaroo-it#19 MagentoFrameworkObjectManagerFactoryCompiled->get() called at [vendor/magento/framework/ObjectManager/Factory/Compiled.php:79] buckaroo-it#20 MagentoFrameworkObjectManagerFactoryCompiled->create() called at [vendor/magento/framework/ObjectManager/Factory/Compiled.php:150] buckaroo-it#21 MagentoFrameworkObjectManagerFactoryCompiled->get() called at [vendor/magento/framework/ObjectManager/Factory/Compiled.php:125] buckaroo-it#22 MagentoFrameworkObjectManagerFactoryCompiled->parseArray() called at [vendor/magento/framework/ObjectManager/Factory/Compiled.php:86] buckaroo-it#23 MagentoFrameworkObjectManagerFactoryCompiled->create() called at [vendor/magento/framework/ObjectManager/ObjectManager.php:70] buckaroo-it#24 MagentoFrameworkObjectManagerObjectManager->get() called at [vendor/magento/framework/App/FrontController.php:86] buckaroo-it#25 MagentoFrameworkAppFrontController->__construct() called at [generated/code/Magento/Framework/App/FrontController/Interceptor.php:14] buckaroo-it#26 MagentoFrameworkAppFrontControllerInterceptor->__construct() called at [vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php:121] buckaroo-it#27 MagentoFrameworkObjectManagerFactoryAbstractFactory->createObject() called at [vendor/magento/framework/ObjectManager/Factory/Compiled.php:108] buckaroo-it#28 MagentoFrameworkObjectManagerFactoryCompiled->create() called at [vendor/magento/framework/ObjectManager/ObjectManager.php:70] buckaroo-it#29 MagentoFrameworkObjectManagerObjectManager->get() called at [vendor/magento/framework/App/Http.php:115] buckaroo-it#30 MagentoFrameworkAppHttp->launch() called at [vendor/magento/framework/App/Bootstrap.php:263] buckaroo-it#31 MagentoFrameworkAppBootstrap->run() called at [pub/index.php:40] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue:
The 'Configure' button onder Sales > Payment Methods is disabled. When Magento_Paypal module is enabled, the configure button is enabled as well. Although the module isn't set as a dependency.
Possible fix:
Replace
isPaymentEnabled($element)function in Block\Adminhtml\System\Config\Fieldset\Payment.php by a function checking wether Buckaroo module is activated, so the configure button is activated whenever the module is activated. Also add a script so the button isn't accidentally getting activated by the Paypal module.The text was updated successfully, but these errors were encountered: