Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BP-3894 Update Applepay.php #1111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgroensmit
Copy link
Contributor

The 'getAvailableButtons' method can return a boolean (false) instead of an array.

I think the getAvailableButtons method should just return an empty array if there are no available buttons, but considering Hyrum's law I would consider that a breaking change requiring a minor version update. This Pull Request should be minimal impact, warranting a release in a patch-version.

@Buckaroo-Rene
Copy link
Contributor

Buckaroo-Rene commented Dec 2, 2024

Hi @mgroensmit,

Thank you for your message! Our team has addressed this issue in the following PR:
BP-3894

The fix will be included in our upcoming release.

@Buckaroo-Rene Buckaroo-Rene changed the title Update Applepay.php BP-3894 Update Applepay.php Dec 2, 2024
@Buckaroo-Rene Buckaroo-Rene self-assigned this Dec 2, 2024
@Buckaroo-Rene Buckaroo-Rene added 👏Thank You✨ Thank you for contributing! Status: Waiting for release This issue has been solved, but is not released yet. Priority: Normal This issue has a normal/medium priority. labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Normal This issue has a normal/medium priority. Status: Waiting for release This issue has been solved, but is not released yet. 👏Thank You✨ Thank you for contributing!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants