Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use type for form schema in feature page #1018

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Conversation

kentakozuka
Copy link
Contributor

part of #1017

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
@kentakozuka kentakozuka marked this pull request as ready for review June 13, 2024 05:33
@kentakozuka kentakozuka requested a review from cre8ivejp as a code owner June 13, 2024 05:33
@cre8ivejp
Copy link
Member

@kentakozuka, the changes are causing many errors in the console.

Screenshot 2024-06-14 at 12 19 33 PM

Also, on the targeting tab, the off variation is not showing.
Probably there are more issues.

Screenshot 2024-06-14 at 12 21 59 PM

@kentakozuka
Copy link
Contributor Author

kentakozuka commented Jun 14, 2024

@cre8ivejp
The errors are not reproduced on my machine
Can you tell me your setup?

  • Browser
  • Nodejs version

btw, Nodejs version is 18 now.

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
@kentakozuka
Copy link
Contributor Author

@cre8ivejp OffVariation issue is fixed 👍

Copy link
Member

@cre8ivejp cre8ivejp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kentakozuka kentakozuka merged commit cebfac1 into main Jun 14, 2024
15 checks passed
@kentakozuka kentakozuka deleted the ui-update branch June 14, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants