fix: add log debug for background task

bucketeer-io · Aug 24, 2023 · 72fd7c4 · 72fd7c4
1 parent de71864
commit 72fd7c4
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 6 deletions.
diff --git a/Bucketeer/Sources/Internal/Scheduler/EvaluationBackgroundTask.swift b/Bucketeer/Sources/Internal/Scheduler/EvaluationBackgroundTask.swift
@@ -20,13 +20,14 @@ final class EvaluationBackgroundTask {
 
         do {
             try BGTaskScheduler.shared.submit(request)
-            component?.config.logger?.debug(message: "The background task is scheduled.")
+            component?.config.logger?.debug(message: "[EvaluationBackgroundTask] The background task is scheduled.")
         } catch {
             component?.config.logger?.error(error)
         }
     }
 
     private func handleAppRefresh(_ task: BGTask) {
+        component?.config.logger?.debug(message: "[EvaluationBackgroundTask] handleAppRefresh")
         // Schedule a new refresh task.
         scheduleAppRefresh()
 
@@ -39,13 +40,18 @@ final class EvaluationBackgroundTask {
                     timeoutMillis: nil,
                     completion: { error in
                         task.setTaskCompleted(success: error == nil)
+                        if let error {
+                            self?.component?.config.logger?.error(error)
+                        } else {
+                            self?.component?.config.logger?.warn(message: "[EventBackgroundTask] success")
+                        }
                     }
                 )
             }
         }
         // Provide the background task with an expiration handler that cancels the operation.
         task.expirationHandler = { [weak self] in
-            self?.component?.config.logger?.warn(message: "The background task is expired.")
+            self?.component?.config.logger?.debug(message: "[EvaluationBackgroundTask] The background task is expired.")
         }
     }
 }

diff --git a/Bucketeer/Sources/Internal/Scheduler/EventBackgroundTask.swift b/Bucketeer/Sources/Internal/Scheduler/EventBackgroundTask.swift
@@ -20,12 +20,14 @@ final class EventBackgroundTask {
 
         do {
             try BGTaskScheduler.shared.submit(request)
+            component?.config.logger?.debug(message: "[EventBackgroundTask] The background task is scheduled.")
         } catch {
             component?.config.logger?.error(error)
         }
     }
 
     private func handleAppRefresh(_ task: BGTask) {
+        component?.config.logger?.debug(message: "[EventBackgroundTask] handleAppRefresh")
         // Schedule a new refresh task.
         scheduleAppRefresh()
 
@@ -35,12 +37,14 @@ final class EventBackgroundTask {
                 task.setTaskCompleted(success: error == nil)
                 if let error {
                     self?.component?.config.logger?.error(error)
+                } else {
+                    self?.component?.config.logger?.warn(message: "[EventBackgroundTask] success")
                 }
             }
         }
         // Provide the background task with an expiration handler that cancels the operation.
         task.expirationHandler = { [weak self] in
-            self?.component?.config.logger?.warn(message: "The background task is expired.")
+            self?.component?.config.logger?.debug(message: "[EventBackgroundTask] The background task is expired.")
         }
     }
 }

diff --git a/Bucketeer/Sources/Public/BKTBackgroundTask.swift b/Bucketeer/Sources/Public/BKTBackgroundTask.swift
@@ -8,17 +8,20 @@ public final class BKTBackgroundTask {
 
     public static func enable() {
         // Register all background task here
-        BGTaskScheduler.shared.register(forTaskWithIdentifier: BackgroundTaskIndentifier.fetchEvaluations, using: nil) { task in
-            forwardTaskToHandler(BackgroundTaskIndentifier.fetchEvaluations, task)
-        }
         BGTaskScheduler.shared.register(forTaskWithIdentifier: BackgroundTaskIndentifier.flushEvents, using: nil) { task in
             forwardTaskToHandler(BackgroundTaskIndentifier.flushEvents, task)
         }
+        BGTaskScheduler.shared.register(forTaskWithIdentifier: BackgroundTaskIndentifier.fetchEvaluations, using: nil) { task in
+            forwardTaskToHandler(BackgroundTaskIndentifier.fetchEvaluations, task)
+        }
     }
 
     private static func forwardTaskToHandler(_ identifier: String, _ task: BGTask) {
         if let handler = handlerRegistry[identifier] {
             handler.handle(task)
+        } else {
+            // no handler
+            task.setTaskCompleted(success: true)
         }
     }