Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove "Test" of configuration #52

Merged
merged 2 commits into from
Nov 14, 2023
Merged

build: remove "Test" of configuration #52

merged 2 commits into from
Nov 14, 2023

Conversation

kakcy
Copy link
Contributor

@kakcy kakcy commented Nov 1, 2023

  • It doesn't make good use of the "Test" configuration, and its settings are almost the same as "Debug".
    Unnecessary configuration complicates the Xcode project and should be removed.
  • Where "Test" is used, it will be changed to "Debug".

@kakcy kakcy marked this pull request as ready for review November 2, 2023 01:57
@kakcy kakcy requested a review from cre8ivejp November 8, 2023 07:01
cre8ivejp
cre8ivejp approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@cre8ivejp cre8ivejp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kakcy kakcy merged commit 7c77b7c into bucketeer-io:main Nov 14, 2023
@bucketeer-bot bucketeer-bot mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cre8ivejp cre8ivejp cre8ivejp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kakcy @cre8ivejp