PROD-7724 - Fix: Count of connection and following in members page. #4498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jitendrabanjara1991
requested changes
Sep 9, 2024
…spended Issue: total_friend_count meta was not updating correctly due to a strict type comparison between user_id (string) and friend_ids (integer). Root Cause: The condition 'hide' === $type && in_array( $user_id, $friend_ids, true ) was failing because in_array was performing a strict type check (true flag), and $user_id was a string while friend_ids were integers. Fix: Cast $user_id to integer before comparison to ensure the condition is satisfied.
- Added a filter to the friendship SQL query that excludes moderated/suspended users. This ensures accurate friendship counts when running the 'Repair total connections count for each member' tool from the admin panel, preventing incorrect counts for users with suspended friendships.
- Add migration code to fix my connection count and remove suspend user from follow table if any user is suspended
…owers for suspend members
…ollowing data was removing from DB )
… Following data was removing from DB )
- Removed suspended users from follower and following count query
… following data when member suspend so, don't require following related code here
KartikSuthar
previously approved these changes
Oct 11, 2024
chetansatasiya
requested changes
Dec 3, 2024
- Use following count directly instead of member template
…dy added action 'bp_core_install'
…d connections count
…ocked users from connections query Details: - Modified logic to retain friendships when a member is blocked. Friendship will resume if the member is unblocked. - Updated database query to exclude suspended and blocked users from the "My Connections" list.
Details: - Updated logic to ensure suspended and blocked members are excluded when fetching friends. - Adjusted the process to fetch all valid friends for further processing.
* release: (35 commits) Update: Grunt Update: Grunt string-replace Update: Version name update updated change log Added change log PROD-8149 - Pulled API changes [PROD-8240] grunt PROD-8378 - Grunt PROD-8378 - Remove code which strip html tags so script tag can remove from draft also fixed jshint PROD-8378 - sanitize topic title when added in draft PROD-8378 - sanitize topic title when add/edit [PROD-8240] Fix moderations table UI issues in mobile screen [PROD-8240] Fix Group and Activity tables UI issues in mobile screen [PROD-8240] Fix error overflow outside container in smaller screens [PROD-8332] Remove open class from message more option wrap once the dropdown is closed [PROD-8310] Fix create new message uploader button UI issue [PROD-8210] Set single profile avatars height to auto for better aspect ratio handling PROD-7492 Code refactor [PROD-8239] Fix Forum search reload page issue [PROD-8240] Update admin card elements spacing and navigation float layout issue ... # Conflicts: # src/bp-templates/bp-nouveau/js/buddypress-nouveau.min.js
… the pending request
…tion is to repair the total friend count for each member. To ensure that the counts are accurate, the function first deletes any existing friend count metadata. This ensures that the counts are recalculated from scratch, avoiding any potential inconsistencies or errors in the existing data.
KartikSuthar
previously approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue:
https://buddyboss.atlassian.net/browse/PROD-7724
General Note
Keep all conversations related to this PR in the associated Jira issue(s). Do NOT add comment on this PR or edit this PR’s description.
Notes to Developer
Notes to Reviewer