feat(cmd): generate shell completion for --node flag

Signed-off-by: budimanjojo <budimanjojo@gmail.com>

cmd/gencommand.go

@@ -1,6 +1,7 @@
 package cmd
 
 import (
+	"github.com/budimanjojo/talhelper/v3/cmd/helpers"
 	"github.com/spf13/cobra"
 )
 
@@ -24,4 +25,5 @@ func init() {
 	gencommandCmd.PersistentFlags().StringSliceVar(&gencommandEnvFile, "env-file", []string{"talenv.yaml", "talenv.sops.yaml", "talenv.yml", "talenv.sops.yml"}, "List of files containing env variables for config file")
 	gencommandCmd.PersistentFlags().StringSliceVar(&gencommandExtraFlags, "extra-flags", []string{}, "List of additional flags that will be injected into the generated commands.")
 	gencommandCmd.PersistentFlags().StringVarP(&gencommandNode, "node", "n", "", "A specific node to generate the command for. If not specified, will generate for all nodes.")
+	_ = helpers.MakeNodeCompletion(gencommandCmd)
 }

cmd/genurl.go

@@ -1,6 +1,7 @@
 package cmd
 
 import (
+	"github.com/budimanjojo/talhelper/v3/cmd/helpers"
 	"github.com/budimanjojo/talhelper/v3/pkg/config"
 	"github.com/spf13/cobra"
 )
@@ -34,4 +35,6 @@ func init() {
 	genurlCmd.PersistentFlags().StringSliceVarP(&genurlKernelArgs, "kernel-arg", "k", []string{}, "Kernel arguments to be passed to the image kernel (ignored when talconfig.yaml is found)")
 	genurlCmd.PersistentFlags().BoolVar(&genurlOfflineMode, "offline-mode", false, "Generate schematic ID without doing POST request to image-factory")
 	genurlCmd.PersistentFlags().BoolVar(&genurlSecureboot, "secure-boot", false, "Whether to generate Secure Boot enabled URL")
+
+	_ = helpers.MakeNodeCompletion(genurlCmd)
 }

cmd/helpers/completions.go

@@ -0,0 +1,27 @@
+package helpers
+
+import (
+	"github.com/budimanjojo/talhelper/v3/pkg/config"
+	"github.com/spf13/cobra"
+)
+
+// MakeNodeCompletion is a wrapper for `cobra.Command.RegisterFlagCompletionFunc`
+// to reuse in commands that want to have `--node` flag completion
+func MakeNodeCompletion(cmd *cobra.Command) error {
+	return cmd.RegisterFlagCompletionFunc("node", func(*cobra.Command, []string, string) ([]string, cobra.ShellCompDirective) {
+		var nodes []string
+		thCfg, _ := cmd.Flags().GetString("config-file")
+		thEnvFiles, _ := cmd.Flags().GetStringSlice("env-file")
+
+		cfg, err := config.LoadAndValidateFromFile(thCfg, thEnvFiles, false)
+		if err != nil {
+			return nil, cobra.ShellCompDirectiveNoFileComp
+		}
+
+		for i := range cfg.Nodes {
+			nodes = append(nodes, cfg.Nodes[i].Hostname)
+			nodes = append(nodes, cfg.Nodes[i].IPAddress)
+		}
+		return nodes, cobra.ShellCompDirectiveNoFileComp
+	})
+}