Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIM refactoring #2

Open
turnerrainer opened this issue Nov 23, 2022 · 3 comments
Open

TIM refactoring #2

turnerrainer opened this issue Nov 23, 2022 · 3 comments
Assignees
@varmoh
Labels
sprint 2 sprint 3 sprint 4 sprint 9

Comments

@turnerrainer
Copy link
Contributor

No description provided.

@turnerrainer turnerrainer moved this to Todo in Maintenance Jun 1, 2023
@rasmusei rasmusei moved this from Todo to In Progress in Maintenance Aug 21, 2023
@turnerrainer turnerrainer moved this to In Progress in Bürokratt Sprint Aug 24, 2023
@RayDNoper
Copy link
Collaborator

  • Few small optimizations, but apart from the commented out code TIM looks pretty fine, no algorithmic "smells" found
  • Fixed some security issues that Snyk suggested, projects still need to upgrade to Spring 3
  • Cleaned up some additional code smells reported by SonarLint

Still up in the air:

  • Lots of commented out code and definitions that might be relevant if this code is reactivated.

@rasmusei rasmusei moved this from In Progress to Acceptance Testing in Bürokratt Sprint Sep 12, 2023
@rasmusei rasmusei assigned turnerrainer and unassigned RayDNoper Sep 12, 2023
@turnerrainer turnerrainer assigned varmoh and unassigned turnerrainer Oct 20, 2023
@turnerrainer turnerrainer moved this from In Progress to Acceptance Testing in Maintenance Oct 20, 2023
@turnerrainer
Copy link
Contributor Author

@varmoh please validate the deployment pipeline.

varmoh pushed a commit that referenced this issue Oct 20, 2023
@RayDNoper
#2 refactoring some more code smells
9be635b
varmoh pushed a commit that referenced this issue Oct 20, 2023
@RayDNoper
#2 Add API documentation
48f2f32
varmoh pushed a commit that referenced this issue Oct 20, 2023
@RayDNoper
#2 TIM refactoring - remove commented out blocks
4f44e65
@varmoh
Copy link
Collaborator

varmoh commented Oct 20, 2023

Image build and tested. No issues.

@varmoh varmoh moved this from Acceptance Testing to Done in Bürokratt Sprint Oct 20, 2023
@varmoh varmoh moved this from Acceptance Testing to Done in Maintenance Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varmoh varmoh

Labels
sprint 2 sprint 3 sprint 4 sprint 9
Projects
Bürokratt Sprint
Status: Done
Maintenance
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@RayDNoper @PaulaMerle @turnerrainer @varmoh @rasmusei