Check input for empty directories #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
emcfarlane
commented
Aug 2, 2024
emcfarlane
commented
Aug 2, 2024
nicksnyder
reviewed
Aug 2, 2024
emcfarlane
force-pushed
the
ed/checkInputDir
branch
from
3ae7eae
to
cea1799
Compare
emcfarlane
force-pushed
the
ed/checkInputDir
branch
from
cea1799
to
69a7b9d
Compare
nicksnyder
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To provide better errors we can map some of the buf errors to config issue errors. It's easy to miss the
- uses: actions/checkout@v4step, provide an annotation to help resolve issues. This adds an info log:/opt/hostedtoolcache/buf/1.35.0/x64/buf build --error-format github-actions Failure: "." had no .proto files +Did you forget to add the "actions/checkout@v4" checkout step to your workflow? Error: Failed build