-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify comments to use logging instead of the Github API #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, much simpler!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, I'm so happy to get rid of all this GitHub API code 👏
src/run.ts
Outdated
// All file annotations in the result have been processed, return an empty error. | ||
return {message: ""}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great, but consider including a more meaningful message rather than an empty error.
return {
message: `buf found ${result.fileAnnotations.length} lint failures.\n
};
This PR does the following:
github.token
(so users no longer need to provide a Github token) and does not require the Github Action to extractowner
,repository
, andpullRequestNumber
fromgithub.context
Files
tab of a pull requestWe plan to make a similar change to
buf-breaking-action