update test

bufbuild · Mar 6, 2024 · 0f6ac24 · 0f6ac24
1 parent 086468c
commit 0f6ac24
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/private/bufpkg/bufcheck/buflint/buflint_test.go b/private/bufpkg/bufcheck/buflint/buflint_test.go
@@ -625,7 +625,8 @@ func TestRunProtovalidateRules(t *testing.T) {
  bufanalysistesting.NewFileAnnotation(t, "number.proto", 35, 5, 35, 43, "PROTOVALIDATE"),
  bufanalysistesting.NewFileAnnotation(t, "number.proto", 39, 5, 39, 43, "PROTOVALIDATE"),
  bufanalysistesting.NewFileAnnotation(t, "number.proto", 42, 5, 42, 42, "PROTOVALIDATE"),
- bufanalysistesting.NewFileAnnotation(t, "number.proto", 45, 48, 48, 4, "PROTOVALIDATE"),
+ bufanalysistesting.NewFileAnnotation(t, "number.proto", 46, 5, 46, 11, "PROTOVALIDATE"),
+ bufanalysistesting.NewFileAnnotation(t, "number.proto", 47, 5, 47, 12, "PROTOVALIDATE"),
  bufanalysistesting.NewFileAnnotation(t, "number.proto", 56, 5, 56, 39, "PROTOVALIDATE"),
  bufanalysistesting.NewFileAnnotation(t, "number.proto", 65, 5, 65, 41, "PROTOVALIDATE"),
  bufanalysistesting.NewFileAnnotation(t, "number.proto", 74, 5, 74, 40, "PROTOVALIDATE"),

diff --git a/private/bufpkg/bufcheck/buflint/testdata/protovalidate_rules/number.proto b/private/bufpkg/bufcheck/buflint/testdata/protovalidate_rules/number.proto
@@ -41,10 +41,10 @@ message Int32Test {
  // the next line should be annotated
  (buf.validate.field).sfixed64.gt = 10
  ];
- // the entire option should be annotated. (45, 48) to (48, 4)
+ // annotating items inside an option value
  fixed32 invalid_bound_aggregate_syntax = 11 [(buf.validate.field).fixed32 = {
- lt: 10
- gte: 10
+ lt: 10 // this line should be annotated
+ gte: 10 // and this one, too
  }];
  // valid
  google.protobuf.Int32Value int32_value_match = 12 [