Skip to content

Commit

Permalink
Fix GetGraphForModuleKeys requiring unique Registries
Browse files Browse the repository at this point in the history
`GetGraphForModuleKeys` was attempting to determine a primary and
secondary registry, but it was doing so by requiring that the Registry
is unique across all deps. Instead, it should simply extract the unique
registries.
  • Loading branch information
saquibmian committed Feb 20, 2024
1 parent 9729f26 commit 7b9fb3f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion private/bufpkg/bufmodule/bufmoduleapi/registry.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func getPrimarySecondaryRegistry[T hasModuleFullName](s []T) (string, string, er
if len(s) == 0 {
return "", "", syserror.New("must have at least one value in getPrimarySecondaryRegistry")
}
registryMap, err := slicesext.ToUniqueValuesMapError(
registryMap, err := slicesext.ToValuesMapError(
s,
func(e T) (string, error) {
moduleFullName := e.ModuleFullName()
Expand Down

0 comments on commit 7b9fb3f

Please sign in to comment.