Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add buftarget package #2799

Merged
merged 32 commits into from
Mar 6, 2024
Merged

Add buftarget package #2799

merged 32 commits into from
Mar 6, 2024

Commits on Mar 4, 2024

  1. Add first draft of buftarget

    @doriable
    doriable committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    410127a View commit details
    Browse the repository at this point in the history

  2. Plumb buftarget through to buffetch/internal 

    This has some failing tests in `reader_test.go` because we are changing
the behaviour of `ProtoFileRef`. We need to wire the logic a couple of
layers up before we change these tests and ensure that everything works.
    @doriable
    doriable committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    33572a5 View commit details
    Browse the repository at this point in the history

  3. WIP

    @doriable
    doriable committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    b3daed0 View commit details
    Browse the repository at this point in the history

  4. fix

    @bufdev @doriable
    bufdev authored and doriable committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    82e1a76 View commit details
    Browse the repository at this point in the history

  5. Clean up ProtoFileRef handling

    @doriable
    doriable committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    8e35869 View commit details
    Browse the repository at this point in the history

  6. Add better fallback logic for workspace targeting

    @doriable
    doriable committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    84d11c9 View commit details
    Browse the repository at this point in the history

  7. Fix all private/buf/cmd/buf integration tests

    @doriable
    doriable committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    5cd61f8 View commit details
    Browse the repository at this point in the history

  8. Fix issue with input paths outside of the current working dir context

    @doriable
    doriable committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    95d6877 View commit details
    Browse the repository at this point in the history

  9. Fix the last of the tests

    @doriable
    doriable committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    8046151 View commit details
    Browse the repository at this point in the history

  10. Fix lint

    @doriable
    doriable committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    859e018 View commit details
    Browse the repository at this point in the history

  11. Rename InputPath to InputDir for bucket targeting for clarity

    @doriable
    doriable committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    36c73b1 View commit details
    Browse the repository at this point in the history

  12. Have slightly nicer fallback check for workspace targeting

    @doriable
    doriable committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    5d6a67b View commit details
    Browse the repository at this point in the history

  13. Fix some windows tests

    @doriable
    doriable committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    e1f62ce View commit details
    Browse the repository at this point in the history

  14. Fix ci

    @doriable
    doriable committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    4121d87 View commit details
    Browse the repository at this point in the history

  15. Fix windows test

    @doriable
    doriable committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    e0498d0 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Clean-up some extraneous changes

    @doriable
    doriable committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    7680c73 View commit details
    Browse the repository at this point in the history

  2. Remove extraneous workspace configuration 

    InputPath, TargetPaths, and TargetExcludePaths are now entirely handled
by buftarget.BucketTargeting, so we can remove these workspace options.
    @doriable
    doriable committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    aa283a7 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/bufmod' into BSR-3326-target-paths

    @doriable
    doriable committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    d0ed762 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'bufmod' into BSR-3326-target-paths

    @bufdev
    bufdev committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e2ef952 View commit details
    Browse the repository at this point in the history

  5. TODO.txt problem solved

    @bufdev
    bufdev committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    80b7c2a View commit details
    Browse the repository at this point in the history

  6. s/InputDir/InputDirPath/g

    @bufdev
    bufdev committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    0c6af1e View commit details
    Browse the repository at this point in the history

  7. Godoc

    @bufdev
    bufdev committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    b9e80d0 View commit details
    Browse the repository at this point in the history

  8. Cleanups

    @bufdev
    bufdev committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    adc6d29 View commit details
    Browse the repository at this point in the history

  9. Add godocs for ControllingWorkspace

    @doriable
    doriable committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    ebd0d76 View commit details
    Browse the repository at this point in the history

  10. Fallback logic should only check target paths if input is not a proto… 

    … file ref
    @doriable
    doriable committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    d9bdb94 View commit details
    Browse the repository at this point in the history

  11. Better error message

    @bufdev
    bufdev committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    93681d8 View commit details
    Browse the repository at this point in the history

  12. Add test case for proto file ref with no workspace or module

    @doriable
    doriable committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    62102b9 View commit details
    Browse the repository at this point in the history

  13. commit

    @bufdev
    bufdev committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    16f05a6 View commit details
    Browse the repository at this point in the history

  14. Merge remote-tracking branch 'origin/BSR-3326-target-paths' into BSR-… 

    …3326-target-paths
    @doriable
    doriable committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    517c389 View commit details
    Browse the repository at this point in the history

  15. Error message cleanup

    @bufdev
    bufdev committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    6965ae1 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. error messages

    @bufdev
    bufdev committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    7dcc76e View commit details
    Browse the repository at this point in the history

  2. Test fixes

    @bufdev
    bufdev committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    b7792f0 View commit details
    Browse the repository at this point in the history