Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support annotated tags for push git metadata #3013

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

emcfarlane
Copy link
Contributor

Fix resolving of annotated tags on push with --git-metadata flag by fetching from the remote and then using --points-at to discover each ref and tag. Currently only lightweight tags are resolved as the commit sha for annotated tags doesn't directly point to the commit.

Fix resolving of annotated tags by fetching from the remote and then
using `--points-at` to discover each ref and tag. Currently only
lightweight tags are resolved as the commit sha for annotated tags
doesn't directly point to the commit.
Copy link
Member

@doriable doriable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me -- it makes sense to grab the annotated tags for a commit the same way we are grabbing remote branches. Thanks for putting this through!

Copy link
Contributor

@saquibmian saquibmian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emcfarlane emcfarlane requested a review from bufdev May 28, 2024 17:46
@emcfarlane emcfarlane merged commit 2dfac93 into main May 28, 2024
11 checks passed
@emcfarlane emcfarlane deleted the ed/gitMetadataRefs branch May 28, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants