Default protoencoding resolver to an empty resolver #3345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the behaviour of protoencoding to always set a resolver on init. Marshaller and Unmarshallers will default to the protoregistry.GlobalTypes if a nil resvoler is passed in. To keep the same behaviour the caller must pass in the GlobalTypes explicitly.
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
bufdev
approved these changes
Sep 26, 2024
doriable
approved these changes
Sep 26, 2024
bufdev
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behaviour of protoencoding to always set a resolver on init, defaulting to the
protoencoding.EmtpyResolver. Currently, Marshaller and Unmarshallers will default to theprotoregistry.GlobalTypesif a nil resolver is set. To keep the same behaviour the caller must pass in the GlobalTypes explicitly.