Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protoc-gen-go and golangci-lint #79

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Update protoc-gen-go and golangci-lint #79

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdfa436
Update protoc-gen-go and golangci-lint
pkwarren Mar 20, 2023
335828e
fix build
pkwarren Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions make/go/dep_golangci_lint.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ $(call _assert_var,CACHE_VERSIONS)
$(call _assert_var,CACHE_BIN)

# Settable
# https://github.com/golangci/golangci-lint/releases 20230219 checked 20230222
# https://github.com/golangci/golangci-lint/releases 20230318 checked 20230320
# Check for new linters and add to .golangci.yml (even if commented out) when upgrading
GOLANGCI_LINT_VERSION ?= v1.51.2
GOLANGCI_LINT_VERSION ?= v1.52.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the linters have been updated to fix issues w/ generics now: golangci/golangci-lint#2649 (comment)


GOLANGCI_LINT := $(CACHE_VERSIONS)/golangci-lint/$(GOLANGCI_LINT_VERSION)
$(GOLANGCI_LINT):
Expand Down
4 changes: 2 additions & 2 deletions make/go/dep_protoc_gen_go.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ $(call _assert_var,CACHE_VERSIONS)
$(call _assert_var,CACHE_BIN)

# Settable
# https://github.com/protocolbuffers/protobuf-go/releases 20230314 checked 20230315
PROTOC_GEN_GO_VERSION ?= v1.29.1
# https://github.com/protocolbuffers/protobuf-go/releases 20230316 checked 20230320
PROTOC_GEN_GO_VERSION ?= v1.30.0


GO_GET_PKGS := $(GO_GET_PKGS) \
Expand Down