Add planetscale/vitess module
#365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unmultimedio
commented
Dec 11, 2023
There was a problem hiding this comment.
Even though the source repo already has a buf.yaml, we're adding one here to control the destination ourselves. See related comment #344 (comment)
| @@ -0,0 +1 @@ | |||
| 770e14433716a816905f267650191319f7d0515b | |||
There was a problem hiding this comment.
Latest git main hash at the moment of opening this PR.
|
Successfully tested (includes LICENSE contents) in #366, see comments there. |
pkwarren
reviewed
Dec 12, 2023
pkwarren
approved these changes
Dec 12, 2023
pkwarren
reviewed
Dec 12, 2023
|
|
||
| # Copy only curated subset of files from that repo into a tmp module dir using `rsync.incl` file | ||
| # on each module's static dir | ||
| --include-from="${module_static_path}/rsync.incl" |
There was a problem hiding this comment.
Nice - this is helpful to see it expanded like this.
|
Re-tested again: #371 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #360