Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protocolbuffers/wellknowntypes module to include go_features.proto #798

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

jhump
Copy link
Member

@jhump jhump commented Dec 17, 2024

As of v29.1, the protobuf releases include the google/protobuf/go_features.proto import.

So, with the next release of the protocolbuffers/wellknowntypes module (v29.2 or v30.0, whichever comes next), we can stop sync'ing the protocolbuffers/gofeatures module and update the README to indicate that it is deprecated and that its contents are now available from the wellknowntypes module instead.

This change is tiny. You can look through the commit history to see additional changes (all rolled back in the final commit) that show how I tested the new config and also demonstrate the correct/expected output.

Copy link

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 17, 2024, 9:18 PM

@jhump
Copy link
Member Author

jhump commented Dec 18, 2024

@unmultimedio, did you want to cast an eye on this before I merge?

Copy link
Member

@unmultimedio unmultimedio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the testing! lgtm

@jhump jhump merged commit 3a637e0 into main Dec 18, 2024
5 checks passed
@jhump jhump deleted the jh/update-wkt-w-gofeatures branch December 18, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants