Update plugins #1342
Merged
Update plugins #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes - connectrpc/kotlin:v0.7.0 - community/mercari-grpc-federation:v1.0.3 - apple/swift:v1.27.0 (with new patch)
mfridman
commented
Jul 10, 2024
| } | ||
| } | ||
|
|
||
| + let extraModuleImports: [String] |
There was a problem hiding this comment.
Moved some of the constants and variables towards the "top" to minimize conflicts.
|
apple/swift generated code diff between v1.26.0 and v1.27.0 buf_connect_demo_eliza_v1_eliza.pb.swift I believe this looks okay, where they changed how the 38c38
< public struct Buf_Connect_Demo_Eliza_V1_SayRequest {
---
> public struct Buf_Connect_Demo_Eliza_V1_SayRequest: Sendable {
51c51
< public struct Buf_Connect_Demo_Eliza_V1_SayResponse {
---
> public struct Buf_Connect_Demo_Eliza_V1_SayResponse: Sendable {
64c64
< public struct Buf_Connect_Demo_Eliza_V1_ConverseRequest {
---
> public struct Buf_Connect_Demo_Eliza_V1_ConverseRequest: Sendable {
77c77
< public struct Buf_Connect_Demo_Eliza_V1_ConverseResponse {
---
> public struct Buf_Connect_Demo_Eliza_V1_ConverseResponse: Sendable {
90c90
< public struct Buf_Connect_Demo_Eliza_V1_IntroduceRequest {
---
> public struct Buf_Connect_Demo_Eliza_V1_IntroduceRequest: Sendable {
103c103
< public struct Buf_Connect_Demo_Eliza_V1_IntroduceResponse {
---
> public struct Buf_Connect_Demo_Eliza_V1_IntroduceResponse: Sendable {
115,123d114
< #if swift(>=5.5) && canImport(_Concurrency)
< extension Buf_Connect_Demo_Eliza_V1_SayRequest: @unchecked Sendable {}
< extension Buf_Connect_Demo_Eliza_V1_SayResponse: @unchecked Sendable {}
< extension Buf_Connect_Demo_Eliza_V1_ConverseRequest: @unchecked Sendable {}
< extension Buf_Connect_Demo_Eliza_V1_ConverseResponse: @unchecked Sendable {}
< extension Buf_Connect_Demo_Eliza_V1_IntroduceRequest: @unchecked Sendable {}
< extension Buf_Connect_Demo_Eliza_V1_IntroduceResponse: @unchecked Sendable {}
< #endif // swift(>=5.5) && canImport(_Concurrency)
< |
pkwarren
reviewed
Jul 10, 2024
| WORKDIR /app | ||
| RUN curl -fsSL -o /app/protoc-gen-connect-kotlin.jar https://repo1.maven.org/maven2/com/connectrpc/protoc-gen-connect-kotlin/0.7.0/protoc-gen-connect-kotlin-0.7.0.jar | ||
|
|
||
| FROM gcr.io/distroless/java17-debian12:latest@sha256:c8c2c236c63d7652b707a05b02d0259db91d5feb357e9dc53942f73c2e001088 |
There was a problem hiding this comment.
We should squash layers here similar to other builds.
There was a problem hiding this comment.
Updated in 1ea0fb8, in case you want to review that separately
Co-authored-by: Philip K. Warren <pkwarren@users.noreply.github.com>
Co-authored-by: Philip K. Warren <pkwarren@users.noreply.github.com>
Co-authored-by: Philip K. Warren <pkwarren@users.noreply.github.com>
pkwarren
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes
import publicapple/swift-protobuf#1539Fix #1340