Add Grpc.Net.Client dependency to grpc/csharp
#1456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perezd
approved these changes
Aug 27, 2024
stefanvanburen
commented
Aug 27, 2024
| @@ -4,6 +4,7 @@ | |||
| </PropertyGroup> | |||
| <ItemGroup> | |||
| <PackageReference Include="Grpc.Net.Common" Version="2.63.0" /> | |||
| <PackageReference Include="Grpc.Net.Client" Version="2.63.0" /> | |||
There was a problem hiding this comment.
technically these don't need to be here as they aren't used in compilation, but we're currently testing to ensure that they match. Ideally we'd separate out this dep from the others, but .. 🤷♂️? Shouldn't matter much.
|
(I probably need to split up this PR into a couple, as the build times for these bazel plugins is long.) |
|
Going to just add this dep moving forward, as grpc/csharp is bumping to 1.66.1 today: f02c183. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching with the
Grpc.Net.Commondependency version.