Support proto2 groups (#640)

bufbuild · Dec 5, 2023 · ce54cf1 · ce54cf1
1 parent b331196
commit ce54cf1
Show file tree

Hide file tree

Showing 27 changed files with 909 additions and 133 deletions.
diff --git a/packages/protobuf-bench/README.md b/packages/protobuf-bench/README.md
@@ -10,5 +10,5 @@ server would usually do.
 
 | code generator      | bundle size             | minified               | compressed         |
 |---------------------|------------------------:|-----------------------:|-------------------:|
-| protobuf-es         | 90,449 b      | 38,193 b | 9,801 b |
+| protobuf-es         | 91,410 b      | 38,462 b | 9,870 b |
 | protobuf-javascript | 394,384 b  | 288,654 b | 45,122 b |
diff --git a/packages/protobuf-conformance/src/gen/google/protobuf/test_messages_proto2_pb.ts b/packages/protobuf-conformance/src/gen/google/protobuf/test_messages_proto2_pb.ts
diff --git a/packages/protobuf-test/extra/proto2.proto b/packages/protobuf-test/extra/proto2.proto
@@ -74,4 +74,23 @@ enum Proto2Enum {
 
 message Proto2ChildMessage {
   optional string string_field = 1;
-}
+}
+
+message Proto2GroupsMessage {
+  optional group Group = 1 {
+    optional int32 int32_field = 1;
+    optional group NestedGroup = 2 {
+      optional string string_field = 1;
+    }
+  }
+  repeated group RepeatedGroup = 2 {
+    optional int32 int32_field = 1;
+  }
+  oneof oneof_with_group {
+    group OneofGroup = 3 {
+      optional bool bool_field = 1;
+    }
+  }
+  optional Group message_field_using_group = 4;
+  optional Group.NestedGroup message_field_using_nested_group = 5;
+}
diff --git a/packages/protobuf-test/src/gen/js/extra/proto2_pb.d.ts b/packages/protobuf-test/src/gen/js/extra/proto2_pb.d.ts
diff --git a/packages/protobuf-test/src/gen/js/extra/proto2_pb.js b/packages/protobuf-test/src/gen/js/extra/proto2_pb.js
diff --git a/packages/protobuf-test/src/gen/js/google/protobuf/test_messages_proto2_pb.js b/packages/protobuf-test/src/gen/js/google/protobuf/test_messages_proto2_pb.js
diff --git a/packages/protobuf-test/src/gen/js/google/protobuf/unittest_custom_options_pb.js b/packages/protobuf-test/src/gen/js/google/protobuf/unittest_custom_options_pb.js