Dependency bump #245
Merged
Dependency bump #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaye81
approved these changes
Oct 3, 2022
timostamm
reviewed
Oct 5, 2022
| "@typescript/vfs": "1.0.0", | ||
| "@types/jest": "^29.0.3", | ||
| "jest": "^29.0.3" | ||
| "@typescript/vfs": "1.4.0", |
There was a problem hiding this comment.
We have to keep this at 1.0.0. We use this pin to avoid npm from hoisting this dependency in packages/protoplugin. It's a terrible hack.
| @@ -37,7 +37,7 @@ | |||
| "dependencies": { | |||
| "@bufbuild/protobuf": "0.1.1", | |||
| "@typescript/vfs": "^1.4.0", | |||
| "typescript": "4.5.2" | |||
| "typescript": "4.8.4" | |||
There was a problem hiding this comment.
We should keep this pinned at the older version. We deliberately don't want to keep this up to date, because updating the TypeScript compiler can change to transpiled code, and we want the generated code to be stable.
protobuf-es/packages/protoplugin/src/ecmascript/transpile.ts
Lines 56 to 58 in 5ae3246
smaye81
pushed a commit
that referenced
this pull request
Oct 6, 2022
smaye81
pushed a commit
that referenced
this pull request
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot batched updates