Improve JSON parse error message #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already provide helpful error messages when JSON input does not have the expected shape. But Message.fromJsonString() passes any JSON syntax errors unmodified. This wraps those errors and adds a prefix with the message type name.
timostamm
commented
Nov 30, 2022
| @@ -71,6 +71,14 @@ describe("google.protobuf.Value", () => { | |||
| }); | |||
| expect(value.toJsonString()).toBe("true"); | |||
| }); | |||
| test("encoding unset value to JSON raises error", () => { | |||
There was a problem hiding this comment.
Unrelated - just adding some coverage here because it is an odd case.
timostamm
deleted the
tstamm/slightly-improve-json-decoding-error-message
branch
Merged
smaye81
added a commit
that referenced
this pull request
Dec 5, 2022
This release includes the following: ## Enhancements * Add plugin option `import_extension` to replace the `.js` extension in import paths by @timostamm in #317 * Improve JSON parse error message by @timostamm in #318 * Make PlainMessage recursive by @smaye81 in #308 ## New Contributors @McTano made their first contribution in #311
smaye81
pushed a commit
that referenced
this pull request
Dec 8, 2022
smaye81
added a commit
that referenced
this pull request
Dec 8, 2022
This release includes the following: ## Enhancements * Add plugin option `import_extension` to replace the `.js` extension in import paths by @timostamm in #317 * Improve JSON parse error message by @timostamm in #318 * Make PlainMessage recursive by @smaye81 in #308 ## New Contributors @McTano made their first contribution in #311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already provide helpful error messages when JSON input does not have the expected shape. But Message.fromJsonString() does not. This wraps errors raised by JSON.parse(), and adds a prefix with the message type name.