V2: Throw errors in ReflectMessage instead of returning them #882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reflection API provided by
ReflectMessage
,ReflectList
, andReflectMap
validates a value before setting it. The methods return an error for an invalid value. For example:The
firstName
field is a string, and callingmsg.set
returns an error.While this pattern works well, returning errors is very uncommon. This PR changes the behavior to throw errors instead. To handle the error, the example above changes to: