failed compile ...Validator.java file

[dimax0505]

I would to try your PGV plugin for validation protobuf messages (lang=java), but i can't compile my project. I faced with error:
[INFO] --- protobuf-maven-plugin:0.5.0:test-compile-custom (protoc-java-pgv) @ pgv-java-grpc ---
[INFO] Compiling 1 proto file(s) to C:\Users\Maksimov-DE\go\src\github.com\envoyproxy\protoc-gen-validate\java\pgv-java-grpc\target\generated-test-sources\protobuf\java-pgv
[ERROR] PROTOC FAILED: C:\Users\Maksimov-DE\go\src\github.com\envoyproxy\protoc-gen-validate\java\pgv-java-grpc\target\generated-test-sources\protobuf\java-pgv/io\envoyproxy\pgv\grpc\HelloValidator.java: No such file or directory

[ERROR] C:\Users\Maksimov-DE\go\src\github.com\envoyproxy\protoc-gen-validate\java\pgv-java-grpc\src\test\proto\hello.proto [0:0]: C:\Users\Maksimov-DE\go\src\github.com\envoyproxy\protoc-gen-validate\java\pgv-java-grpc\target\generated-test-sources\protobuf\java-pgv/io\envoyproxy\pgv\grpc\HelloValidator.java: No such file or directory

I try to run test from you repo - pgv-gava-jrpc with same error... Can you say, what i do wrong?

[rmichela]

It looks like you are compiling on Windows. How are you building PGV?

[dimax0505]

Yes, I cloned your project, and build PGV localy on Windows.

[rmichela]

I think I fixed this in a PR #186 I'm working on. Since you have a local clone, can you verify by changing line 126 of templates/java/register.go to

fullPath := strings.Replace(javaPackage(f), ".", string(os.PathSeparator), -1)

https://github.com/envoyproxy/protoc-gen-validate/pull/186/files#diff-7861baaaa3aaaaead65cf98ebb8cc3e1R126

[dimax0505]

Now i clone rmichela:bugfix/java-multiple-files and have same error...
fullPath := strings.Replace(javaPackage(f), ".", string(os.PathSeparator), -1) - correctly now...

[dimax0505]

I haven't figered out yet, how to implement validatoin function to my own applycation (spring boot grpc hello server), but pgv-java-grpc module passed test successful now. I compiled PGV with corrected func JavaMultiFilePath in register.go like this -
func JavaMultiFilePath(f pgs.File, m pgs.Message) pgs.FilePath {
//fullPath := strings.Replace(javaPackage(f), ".", string(os.PathSeparator), -1)
fileName := classNameMessage(m) + "Validator.java"
filePath := pgs.JoinPaths(/*fullPath, */ fileName)
return filePath
}
if you have some instructions how integrate validator in my application, I would be thanckfull!

[skyrocknroll]

@rmichela Any hints on how to integrate pgv into java application would be really helpful. I am able to successfully compile and it generated java-pgv packages. There is no clue on how to integrate with grpc service implementation.

[skyrocknroll]

#202

[rmichela]

@dimax0505 Can you try now with the latest -SNAPSHOT release?

[dimax0505]

https://oss.sonatype.org/content/repositories/snapshots/io/envoyproxy/protoc-gen-validate/ i add dependency from this repository, but have same error...

[skyrocknroll]

@dimax0505 did you do mvn clean compile -U to force update the snapshot?

[dimax0505]

yes:
[INFO] --- protobuf-maven-plugin:0.6.1:test-compile-custom (protoc-java-pgv) @ pgv-java-grpc ---
Downloading: https://oss.sonatype.org/content/repositories/snapshots/io/envoyproxy/protoc-gen-validate/protoc-gen-validate/0.1.0-SNAPSHOT/maven-metadata.xml
Downloading: https://repo.maven.apache.org/maven2/io/envoyproxy/protoc-gen-validate/protoc-gen-validate/0.1.0-SNAPSHOT/maven-metadata.xml
Downloading: http://repository.sonatype.org/content/repositories/releases/io/envoyproxy/protoc-gen-validate/protoc-gen-validate/0.1.0-SNAPSHOT/maven-metadata.xml
Downloading: https://oss.sonatype.org/content/repositories/snapshots/io/envoyproxy/protoc-gen-validate/protoc-gen-validate/0.1.0-SNAPSHOT/maven-metadata.xml
Downloaded: https://oss.sonatype.org/content/repositories/snapshots/io/envoyproxy/protoc-gen-validate/protoc-gen-validate/0.1.0-SNAPSHOT/maven-metadata.xml (4 KB at 3.7 KB/sec)
Downloaded: https://oss.sonatype.org/content/repositories/snapshots/io/envoyproxy/protoc-gen-validate/protoc-gen-validate/0.1.0-SNAPSHOT/maven-metadata.xml (4 KB at 3.7 KB/sec)
Downloading: https://oss.sonatype.org/content/repositories/snapshots/io/envoyproxy/protoc-gen-validate/protoc-gen-validate/0.1.0-SNAPSHOT/protoc-gen-validate-0.1.0-20190526.214922-6.pom
Downloaded: https://oss.sonatype.org/content/repositories/snapshots/io/envoyproxy/protoc-gen-validate/protoc-gen-validate/0.1.0-SNAPSHOT/protoc-gen-validate-0.1.0-20190526.214922-6.pom (10 KB at 19.4 KB/sec)
Downloading: https://oss.sonatype.org/content/repositories/snapshots/io/envoyproxy/protoc-gen-validate/protoc-gen-validate/0.1.0-SNAPSHOT/protoc-gen-validate-0.1.0-20190526.214922-6-windows-x86_64.exe
Downloaded: https://oss.sonatype.org/content/repositories/snapshots/io/envoyproxy/protoc-gen-validate/protoc-gen-validate/0.1.0-SNAPSHOT/protoc-gen-validate-0.1.0-20190526.214922-6-windows-x86_64.exe (11446 KB at 1964.2 KB/sec)
[INFO] Compiling 1 proto file(s) to C:\Users\17318390\IdeaProjects\protoc-gen-validate\java\pgv-java-grpc\target\generated-test-sources\protobuf\java-pgv
[ERROR] PROTOC FAILED: C:\Users\17318390\IdeaProjects\protoc-gen-validate\java\pgv-java-grpc\target\generated-test-sources\protobuf\java-pgv/io\envoyproxy\pgv\grpc\asubpackage\HelloRequestValidator.java: No such file or directory

[ERROR] C:\Users\17318390\IdeaProjects\protoc-gen-validate\java\pgv-java-grpc\src\test\proto\hello.proto [0:0]: C:\Users\17318390\IdeaProjects\protoc-gen-validate\java\pgv-java-grpc\target\generated-test-sources\protobuf\java-pgv/io\envoyproxy\pgv\grpc\asubpackage\HelloRequestValidator.java: No such file or directory

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13.246 s
[INFO] Finished at: 2019-05-27T09:13:19+03:00
[INFO] Final Memory: 15M/209M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:test-compile-custom (protoc-java-pgv) on project pgv-java-grpc: protoc did not exit cleanly. Review output for more information. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

[rmichela]

There is a forward slash between java-pgv and io/envoyproxy. Is that what is causing the problem?

[dimax0505]

yes... but now, i change com.google.protobuf:protoc:3.6.1 to 3.8.0 and error disappear... i don't undestand it... I will try test it on my app in local network, one qwestion - were artefacts in repo https://oss.sonatype.org/content/repositories/snapshots/io/envoyproxy/protoc-gen-validate been generated from master branch of current project?

[rmichela]

Yes. Everything is built from master.

[rmichela]

i change com.google.protobuf:protoc:3.6.1 to 3.8.0 and error disappear

I have no way to reproduce your problem, but the fact that upgrading protoc fixed your build makes me think this is a bug in protoc and not PGV. @rodaine, what do you think?

[rmichela]

@keith Are you also having trouble building on Windows with protoc 3.6.1?

[rodaine]

@rodaine, what do you think?

After fixing the slash issue, what was the error reported by 3.6.1, @dimax0505?

[dimax0505]

@rodaine, what do you think?

After fixing the slash issue, what was the error reported by 3.6.1, @dimax0505?

sorry, i don't clear undestend your question...
i try two way - first - #191 (comment) - i change file templates/java/register.go, and now it work in my local project.
second - i change 3.6.1 to 3.8.0...
if you talk about snapshot-0.2.0 - i don't try it yet...

[rmichela]

second - i change 3.6.1 to 3.8.0

Did this fix your problem?

[dimax0505]

yes, thanks, i closing issue...