Update bazel build to use new naming convention #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tanya Bouman <tanyabouman@gmail.com>
akonradi
suggested changes
May 17, 2021
Signed-off-by: Tanya Bouman <tanyabouman@gmail.com>
|
I'm very excited for this to merge |
Signed-off-by: Tanya Bouman <tanyabouman@gmail.com>
|
Looks good, just waiting for CI now. |
|
Anything holding this up from getting merged? |
akonradi
approved these changes
Jun 10, 2021
|
@derekperkins nope, just forgot to check back after CI finished |
|
I'd love to see this in a release to see if it solves bazel-contrib/bazel-gazelle#988 |
qwertyp4nts
pushed a commit
to qwertyp4nts/protoc-gen-validate
that referenced
this pull request
Jun 15, 2021
* update the bazel build Signed-off-by: Tanya Bouman <tanyabouman@gmail.com> * add alias for validate to validate_go Signed-off-by: Tanya Bouman <tanyabouman@gmail.com> * add deprecation notices for go_default_library aliases Signed-off-by: Tanya Bouman <tanyabouman@gmail.com> Co-authored-by: Alex Konradi <akonradi@google.com> Signed-off-by: Mila <milakosc@gmail.com>
ihtkas
added a commit
to ihtkas/bazel-gazelle-ex
that referenced
this pull request
Oct 3, 2021
The PR bufbuild/protoc-gen-validate#471 fixes to use new bazel naming convention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Gazelle now uses the last component of the Bazel package, rather than
go_default_libraryas thego_libraryname.This causes problems when the naming conventions do not match.
bazel-contrib/bazel-gazelle#988
Adding support for the new naming convention should not break anything that depends on using the old naming convention, because the Gazelle option
import_aliasmakes aliases to the libraries and this allows the old naming convention to still work.There's also a minor update in dependencies.bzl and some additional Gazelle directives so that Gazelle doesn't break things when it runs.