Tolerate missing field tags #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
reviewed
Mar 1, 2024
Comment on lines
+559
to
+565
| Error: `syntax = "proto2"; | ||
| message Foo { | ||
| int32 bar = 1 []; | ||
| optional int32 bar = 1 []; | ||
| }`, | ||
| NoError: `syntax = "proto3"; | ||
| NoError: `syntax = "proto2"; | ||
| message Foo { | ||
| int32 bar = 1 [default=1]; | ||
| optional int32 bar = 1 [default=1]; |
There was a problem hiding this comment.
If you want to preserve these testing a field declaration w/ no label, you could instead change the option from the proto3-disallowed default to something like json_name="foo".
There was a problem hiding this comment.
I beleive label doesn't actually change the test coverage, it is testing the compact option rules only
|
How do I turn the more lenient parsing off? There should be an option (for this, and anything else that was made more lenient), so that |
|
@bufdev, you don't need an option for that. All compile operations do the validation -- it's just been moved from the parse stage to the descriptor production/validation stage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While still returning an error. See #200
Note that the error occurs during validation instead of parsing to eventually allow algorithmic field tag assignments.