Add opt-in function for editions #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd MapEntryNode provide ast.MessageDeclNode to follow suit
…est case for same scenario with edition 2023
jhump
force-pushed
the
jh/validate-feature-usage
branch
from
0569d90 to
1456188
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is temporary and will be removed once support for editions is fully completed. But we need to be able to test editions functionality (what's implemented here so far) integrated into other tools (like the Buf CLI), and we can't wait for editions support to be fully complete because that will likely need to wait on a v27 release candidate of protobuf, updating the protobuf-go module with v27's
descriptor.protochanges, and then using that updateddescriptorpbpackage to implement the final changes needed (to enforce which features are allowed to be used in which editions).