Found and fixed a bug in FieldDescriptor.Cardinality implementation #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcfarlane
approved these changes
Apr 6, 2024
timostamm
approved these changes
Apr 6, 2024
| @@ -1047,6 +1047,12 @@ func (f *fldDescriptor) Cardinality() protoreflect.Cardinality { | |||
| case descriptorpb.FieldDescriptorProto_LABEL_REQUIRED: | |||
| return protoreflect.Required | |||
| case descriptorpb.FieldDescriptorProto_LABEL_OPTIONAL: | |||
| if f.Syntax() == protoreflect.Editions { | |||
There was a problem hiding this comment.
Might be worth adding a comment that explaining that FieldDescriptorProto.label is always set to LABEL_OPTIONAL for editions.
kralicky
pushed a commit
to kralicky/protocompile
that referenced
this pull request
Apr 12, 2024
…ufbuild#270) Updates the descriptor implementation tests to check a few other attributes, which uncovered a bug in the `Cardinality` method, which should report "required" for editions fields where `features.field_presence == LEGACY_REQUIRED`. (cherry picked from commit a556a4b)
kralicky
pushed a commit
to kralicky/protocompile
that referenced
this pull request
Apr 12, 2024
…ufbuild#270) Updates the descriptor implementation tests to check a few other attributes, which uncovered a bug in the `Cardinality` method, which should report "required" for editions fields where `features.field_presence == LEGACY_REQUIRED`. (cherry picked from commit a556a4b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the descriptor implementation tests to check a few other attributes, which uncovered a bug in the
Cardinalitymethod, which should report "required" for editions fields wherefeatures.field_presence == LEGACY_REQUIRED.