Move internal editions code to new internal/editions package #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
force-pushed
the
jh/internal-editions-pkg
branch
from
5ef9f1c to
46dc6b6
Compare
emcfarlane
approved these changes
Apr 12, 2024
kralicky
pushed a commit
to kralicky/protocompile
that referenced
this pull request
Apr 14, 2024
…d#280) This is a pre-factoring step so we can expose some editions-related helper functions from the `protoutil` package without ending up with an import cycle. So this moves the shared stuff out of the `linker` package and into an internal one. It also consolidates the editions-related stuff into one place, so it moves some things from `internal` -> `internal/editions`. (cherry picked from commit 0c62e63)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pre-factoring step so we can expose some editions-related helper functions from the
protoutilpackage without ending up with an import cycle. So this moves the shared stuff out of thelinkerpackage and into an internal one. It also consolidates the editions-related stuff into one place, so it moves some things frominternal->internal/editions.