Correctly handle groups in FieldDescriptor.TextName #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
force-pushed
the
jh/fix-group-text-name
branch
from
f6814f9 to
62290ce
Compare
emcfarlane
approved these changes
May 2, 2024
| // and the message type is a sibling whose name is a mixed-case version of the field name. | ||
| return f.Kind() == protoreflect.GroupKind && | ||
| f.Message().FullName().Parent() == f.FullName().Parent() && | ||
| string(f.Name()) == strings.ToLower(string(f.Message().Name())) |
There was a problem hiding this comment.
Could f.Name() not be mixed case for a group? Assuming it's fine.
There was a problem hiding this comment.
It could be all upper-case. But the compiler requires the group name to start with a capital letter, so it is almost always mixed-case due use of PascalCase naming convention. The corresponding field name is never identical to the type name, because the type contains at least one capital letter whereas the field name is always lower-case.
kralicky
pushed a commit
to kralicky/protocompile
that referenced
this pull request
May 19, 2024
(cherry picked from commit 3ded041)
kralicky
pushed a commit
to kralicky/protocompile
that referenced
this pull request
Jun 8, 2024
(cherry picked from commit 3ded041)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.