Fix a typo in code that adapts/re-parses features to match a descriptor #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcfarlane
approved these changes
May 10, 2024
|
@emcfarlane, in case you want to take another quick look: I figured out a way to exercise this code path and repro the issue. In the tests for the exported |
|
Nice! |
kralicky
pushed a commit
to kralicky/protocompile
that referenced
this pull request
May 19, 2024
…or (bufbuild#305) (cherry picked from commit 752249d)
kralicky
pushed a commit
to kralicky/protocompile
that referenced
this pull request
Jun 8, 2024
…or (bufbuild#305) (cherry picked from commit 752249d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still trying to figure out how to formulate a test that can catch this (since this code path was clearly not covered by existing tests 🤦).