Add wellknownimports package, for providing actual source code for the standard imports #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
force-pushed
the
jh/wellknownimports
branch
from
55af3d5 to
e01bb2d
Compare
jhump
force-pushed
the
jh/wellknownimports
branch
from
e01bb2d to
f8a8f67
Compare
jhump
force-pushed
the
jh/wellknownimports
branch
from
f8a8f67 to
8265cba
Compare
|
ping @emcfarlane |
emcfarlane
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the last bullet mentioned in #309 -- it provides a resolver for source code of the standard imports. It's in a separate package so users that don't import it don't pay any cost of the embedded source files.
This allows the compiler to make use of the extension declarations added to
descriptor.protoin v27.0.