Map fields and message values in map entries cannot be group-encoded #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
force-pushed
the
jh/maps-cant-be-groups
branch
from
5e1aa4c to
60d821e
Compare
emcfarlane
approved these changes
Jun 4, 2024
kralicky
pushed a commit
to kralicky/protocompile
that referenced
this pull request
Jun 19, 2024
…ufbuild#312) (cherry picked from commit 604d705)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was tempted to just wait for https://go-review.googlesource.com/c/protobuf/+/588976 to land since that is 🤞 hopefully imminent. I may still wait for that and then make a minor change in this branch to remove the TODO. But in case that gets stalled, we can still proceed with this so at least our implementation behaves correctly.