Allow reserved extension declaration to specify full_name and type as long as they specify both #327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic was incorrect and failed to mirror protoc. The test case, which verifies that protoc succeeds or fails when protocompile does, was not correctly formulated so gave false confidence that the logic was correct.
Previously, this disallowed extension declarations that were reserved that also had a
full_name
ortype
attribute specified.With this change, it is allowed as long as both
full_name
andtype
are specified. It is only an error when only one of them is set.