Implement machine-applicable suggestions in diagnostics #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
report.SuggestEdits, which allows diagnostics to suggest changes to an annotated span. This will be used for surfacing quick-fixes in the LSP (for example, for suggesting deleting unused imports, adding asyntaxdeclaration, adding missing field numbers, and so on).The compiler is also able to render these as a simple diff, similar to some of rustc's diagnostics. I've tried to keep the data model simple: no diffing actually happens, the diagnostics are expected to generate the diffs manually. All the renderer does is convert the edits into hunks to show to the user. This PR contains examples in the lexer that shows how it is meant to be used.