Use IsZero and "zero" instead of Nil and "nil" for pointer-like types (except arena.Pointer)
#402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
approved these changes
Dec 19, 2024
experimental/ast/decl.go
Outdated
| @@ -23,7 +23,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| DeclKindNil DeclKind = iota | |||
| DeclKindZero DeclKind = iota | |||
There was a problem hiding this comment.
Maybe we could call the zero kinds "Invalid" or "Undefined"? So a zero value has an invalid/undefined kind. WDYT?
There was a problem hiding this comment.
This comment was really directed at all kinds, not just DeclKind. Sorry if that wasn't clear. See #405.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly a cosmetic change.
However, this was also an opportunity to ensure that every accessor-like method on AST types returns zero, instead of randomly panicking as is the case now. This is enforced by a test.