Implement shared field constraints #176
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtensionRegistry
and aTypeRegistry
for resolving protobuf messages. Ordinarily, only aTypeRegistry
would necessarily be needed. However, we need to be able to resolve extensions defined in file descriptor sets we don't control, which means we need to be able to reparse to and from the user's descriptors in the worst case: to the user's descriptors to get the extended rule message (whose message type descriptors may have a different hashcode and thus may not resolve using just anExtensionRegistry
alone) and back from the user's descriptors in order to parse thepriv
/shared
field.rule
variable.ExtensionRegistry
and aTypeRegistry
. This enables the conformance runner to pass both the old conformance test suite and the new one, regardless of whether the proto descriptors match up.TODO:
This will depend on bufbuild/protovalidate#246.