Fix integer overflow bug in validation error message

[lyang]

Symptom

Some standard validation error messages have Integer Overflow bug on large decimal values.

Example

message LargeValue {
  uint64 count = 1 [(buf.validate.field).uint64 = {gte: 0, lte: 999999999999}];
}

@Test
public void validate_count() {
  LargeValue value = LargeValue.newBuilder().setCount(9999999999999).build();
  ValidationResult result = new Validator().validate(value);
  assertThat(result.getViolations().get(0).getMessage()).isEqualTo("value must be greater than or equal to 0 and less than or equal to 999999999999");
  // Above fails with: "value must be greater than or equal to 0 and less than or equal to -727379969"
}

Cause

This is due to %s interpreted as String in Format.java:

// ...
        case 's':
          formatString(builder, arg);
          break;
// ...

which eventually calls:

// ...
    } else if (type == TypeEnum.Int || type == TypeEnum.Uint) {
      formatInteger(builder, Long.valueOf(val.intValue()).intValue());
// ...

Note

Originally fixed in a different way in bufbuild/protovalidate#144

[lyang]

Hi,
Just want to check in and see if there's a release scheduled soon?

Thanks!

[nicksnyder]

Just released 0.1.9