Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use slices from stdlib over golang.org/x/exp/slices #134

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

oliversun9
Copy link
Contributor

Using golang.org/x/exp/slices might cause problems like

../protovalidate/tools/protovalidate-conformance/internal/results/result.go:226:30: type func(a *validate.Violation, b *validate.Violation) bool of func(a, b *validate.Violation) bool {…} does not match inferred type func(a *validate.Violation, b *validate.Violation) int for func(a E, b E) int

especially when you are in a Go workspace.

@oliversun9 oliversun9 requested a review from rodaine November 20, 2023 16:35
@oliversun9 oliversun9 merged commit d4541f4 into main Nov 20, 2023
3 checks passed
@oliversun9 oliversun9 deleted the osun/use-slice-from-stdlib branch November 20, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants