Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test big integers in constraints #146

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Test big integers in constraints #146

merged 3 commits into from
Dec 27, 2023

Conversation

nicksnyder
Copy link
Member

Intentionally use large numbers in tests cases to help catch implementation errors like this: #144

@nicksnyder nicksnyder requested a review from rodaine December 18, 2023 22:20
Copy link
Member

@rodaine rodaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create new messages and cases for this? That way we can make it explicit why we're using these extreme numbers.

@nicksnyder
Copy link
Member Author

yep, can do

@nicksnyder nicksnyder requested a review from rodaine December 20, 2023 03:03
@nicksnyder
Copy link
Member Author

I ran tests in the repo, but they don't actually test the test cases I added. Am I supposed to run this locally against protovalidate-go or something to sanity check?

Copy link
Member

@rodaine rodaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! If you want to verify against an implementation, you can build the conformance harness and execute it against an implementation directly. For protovalidate-go, if you build into its .tmp/bin directory you can override the configured version built by the Makefile.

@nicksnyder
Copy link
Member Author

Thanks, tested against protovalidate-go and it passes.

@nicksnyder nicksnyder merged commit 44761c4 into main Dec 27, 2023
3 checks passed
@nicksnyder nicksnyder deleted the largeint branch December 27, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants