Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel: add MODULE.bazel files for bzlmod #175

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmorel-35
Copy link

@mmorel-35 mmorel-35 commented Feb 25, 2024

I'm trying a migration to bzlmod here.

go_googleapis is missing here because rules_go has removes it from it's dependencies

Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com

@mmorel-35 mmorel-35 marked this pull request as ready for review February 25, 2024 21:25
@mmorel-35 mmorel-35 marked this pull request as draft February 25, 2024 21:55
Copy link
Member

@rodaine rodaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to make any changes to CI to use bzlmod?

MODULE.bazel Outdated Show resolved Hide resolved
@mmorel-35
Copy link
Author

Do we need to make any changes to CI to use bzlmod?

Bzlmod itself doesn't require it but something else could.

While running generate-bazel an extra buf_push appears and it's not yet available in a release yet.

So I'm wondering if it's not too early to use bzlmod after all

@rodaine rodaine marked this pull request as ready for review February 26, 2024 22:33
@rodaine rodaine marked this pull request as draft February 26, 2024 22:33
@rodaine
Copy link
Member

rodaine commented Feb 26, 2024

Bzlmod itself doesn't require it but something else could.

(Sorry, unfamiliar with bzlmod and only weakly familiar with bazel as a whole)

I mean, do we need to execute anything in CI to ensure that the module works with bzlmod.

@mmorel-35 mmorel-35 force-pushed the bzlmod branch 2 times, most recently from 3cb41b1 to 808d068 Compare March 2, 2024 12:18
@mmorel-35
Copy link
Author

To enable bzlmod, you need to use --enable_bzlmod argument in your command line.

  • bazel build --enable_bzlmod //example/... because of the absence of go_googleapis.
  • bazel build --enable_bzlmod //proto/... is working

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants