Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vestigial migrator configuration #19

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Conversation

rodaine
Copy link
Member

@rodaine rodaine commented Jun 8, 2023

Vestigial parameters on the migrator struct were being used instead of the actual Config values, making the tool not emit anything. This patch removes those fields and consults the config correctly.

Thanks @shuqingzai for the bug report!
Fixes #15

@rodaine rodaine merged commit 47de4e8 into main Jun 8, 2023
@rodaine rodaine deleted the rodaine/fix-migrator-config branch June 8, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] tools/protovalidate-migrate command error
2 participants