Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrator: properly handle ignore generation on fields #209

Merged
merged 2 commits into from
May 7, 2024

Conversation

rodaine
Copy link
Member

@rodaine rodaine commented May 7, 2024

ignore field migration (from ignore_empty and skipped) was preserving the field type (e.g., string or repeated) in the new format, which is erroneous. required was already handling this correctly, ignore just slipped through the cracks here.

Fixes #202

Thanks again @pquerna & @jschaf for the reports!

@rodaine rodaine requested a review from pkwarren May 7, 2024 17:12
@rodaine rodaine merged commit df918ea into main May 7, 2024
3 checks passed
@rodaine rodaine deleted the rodaine/fix-migrator-ignore branch May 7, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] migration tool: repeated strings with ignore_empty doesn't work
2 participants