-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cel expressions for standard constraints with bool type #252
Conversation
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Can we add conformance tests that check these as well as run it against protovalidate-go to verify? Thanks @oliversun9! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes mostly LGTM though I echo the sentiment re: adding conformance test cases, definitely a good idea.
I added tests and build pvgo's conformance test binary with locally generated protovalidate code, and they pass 😄
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, passes just fine. This does however make me realize that I need to improve the reparse logic on my branch. Even with my new improvements, I still couldn't get conformance passing without updating the gencode. (This is wrong, conformance should pass in the future even with completely mismatched gencode.)
This fixes the problem where
still validates for
tuuid
by updating cel expressions to pass if the option is set to false.