Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bytes.pattern doc clarity #266

Closed
wants to merge 2 commits into from
Closed

Update bytes.pattern doc clarity #266

wants to merge 2 commits into from
+5 −4

Conversation

rodaine
Copy link
Member

@rodaine rodaine commented Oct 17, 2024

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 17, 2024, 7:28 PM

@rodaine
Copy link
Member Author

rodaine commented Oct 21, 2024

It turns out this was actually accurate. Internally, we're casting the bytes field to a string before applying the regex. CEL produces a runtime error if that value is not UTF-8 (at least in cel-go). We'll likely need to add an overload for matches that supports bytes (and/or upstream this overload).

@rodaine rodaine closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alfus Alfus Alfus approved these changes

@jchadwick-buf jchadwick-buf jchadwick-buf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodaine @Alfus @jchadwick-buf