Make now stable variable instead of function #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alfus
approved these changes
May 30, 2023
rodaine
added a commit
to bufbuild/protovalidate-go
that referenced
this pull request
May 30, 2023
Implementing changes introduced in bufbuild/protovalidate#6
pkwarren
pushed a commit
that referenced
this pull request
Jul 18, 2023
…roto modified package of validate.proto
igor-tsiglyar
pushed a commit
to igor-tsiglyar/protovalidate
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CEL expects expressions to be pure, which the
now()function we previously introduced would violate. To avoid this, and to align with other implementations, we're going to make now a global variable instead, so that it may be consistent within a single expression. The value can be lazily resolved in an activation to avoid overhead of resolving this variable on every expression.Updated conformance tests to ensure
now == nowwithin an expression.