Add more examples #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliversun9
commented
Sep 19, 2023
| // `gte = +inf` validates that the number must be greater than positve infinity. | ||
| // This means mystery_index must be +inf. | ||
| // protoc fails to compile this line but Buf compiles it successfully: | ||
| // float mystery_index = 3 [(buf.validate.field).float.gte = +inf]; |
There was a problem hiding this comment.
It seems protoc cannot compile this line, and make test fails at this line.
bufdev
approved these changes
Sep 19, 2023
|
Merging this as-is and let's continue to improve it later |
emcfarlane
added a commit
that referenced
this pull request
Sep 21, 2023
Tiny fix from #93 adds back the links in the examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
option_*cover most features from the standard options.cel_*cover most features from CEL's feature list. Exception:getFooFromBarfamily, includinggetDate,getDayOfMonth,getDayOfYear,getFullYear,getHours,getMilliseconds,getMinutes,getMonthandgetSeconds, onlygetDayOrWeekis covered, but there is a comment mentioning all the rest and a link to this feature list.cel_*also cover custom CEL functions and overloads